Multiple settings tabs always return to first tab after save

[Blob]

With multiple settings pages (tabs) the page always returns to the first tab after a save.
To me it looks much cleaner if you stay on the tab you just saved.

Setting SelectedPageIndex doesn't seem to do much, but maybe i am missing something.

Any hints?

[rmasonjr]

If you look in HomeSeer's html folder, you can see how their setup.html page works. They appear to use a requested_tab and set the property to 'active' if the tab.id==requested_tab.

In your plugin, you would need to do something similar. Just use a global variable for the last tab that was displayed and set the property accordingly.

[alexbk66]

When I add a page to settings - I specify the display order, then when returning list of pages in OnSettingsLoad() I sort pages by order.

This way I can control the display order and keep on the current page by setting the order to minimum.

But I guess it's difficult to know "the tab you just saved", because from the callback point of view all tabs are just a set of views.

I work out the current tab by the view which was modified.

[Blob]

But I guess it's difficult to know "the tab you just saved", because from the callback point of view all tabs are just a set of views.
I work out the current tab by the view which was modified.

Using

Settings.IndexOf(pageId)

in OnSettingChange to find "the tab you just saved" seems to work fine.

[alexbk66]

Using

Settings.IndexOf(pageId)

in OnSettingChange to find "the tab you just saved" seems to work fine.

But you need to pass pageId? What's that?

[Blob]

But you need to pass pageId? What's that?

Try this:

 protected override bool OnSettingChange(string pageId, AbstractView currentView, AbstractView changedView) {
    Console.WriteLine($"Page:{pageId} (PageIndex:{Settings.IndexOf(pageId)}) has changed value of id:{changedView.Id} to {changedView.GetStringValue()}");
 }

[Blob]

If you look in HomeSeer's html folder, you can see how their setup.html page works. They appear to use a requested_tab and set the property to 'active' if the tab.id==requested_tab.

In your plugin, you would need to do something similar. Just use a global variable for the last tab that was displayed and set the property accordingly.

Fairly easy on a feature page, but what would be the best way to get extra tags on a settings page?

[rmasonjr]

I gave up on settings pages long ago...

[alexbk66]

I gave up on settings pages long ago...

It's not too bad

[rmasonjr]

That looks great, Alex!

I just didnt like that I couldnt make changes to the layout, such as adding columns, or display repeating data. I also couldnt figure out how to load the settings for editing so I gave up and just used Feature Pages which give me much more control over the layout and behavior.



Ignore the yellow heading - it reminds me I am on my development instance instead of production

[alexbk66]

I just didnt like that I couldnt make changes to the layout, such as adding columns, or display repeating data

HST added Grid view later, but I can't be bothered now. The only downside of Settings pages - you can't get immediate callback from, say, checkboxes - so you can't dynamically change the UI, you need to click Save first...

[Blob]

When I add a page to settings - I specify the display order, then when returning list of pages in OnSettingsLoad() I sort pages by order.

This way I can control the display order and keep on the current page by setting the order to minimum.

But I guess it's difficult to know "the tab you just saved", because from the callback point of view all tabs are just a set of views.

I work out the current tab by the view which was modified.

Swapping the modified tab to index 0 does work and seems like a viable workaround for now.
Still it would be far nicer to be able to select the active tab like (I guess) the SelectedPageIndex property is supposed to do.