Cleaner version of script

[Guest]

Wrote this small script to optimize a device string for Hstouch display;
still learning to script VB so pretty sure there is a cleaner way to get the same result, open to ideas to optimize this:

Sub Main(ByVal Parms as String)

Dim X As String = hs.DeviceString(2405)
Dim Y As String
Dim Z As String
Dim A As String

Y = Replace(X, "km/h", "")
Z = Replace(Y, "rafale", "-")
A = Replace(Z, " ", "")
hs.SetDeviceString(8622, A, true)

End Sub

"O 32 km/h rafale 46 km/h"
becomes
"O32-46"

[jon00]

You can shorten it to:

        Dim X As String = hs.DeviceString(2405).Replace(X, "km/h", "").Replace(Y, "rafale", "-").Replace(Z, " ", "")
        hs.SetDeviceString(8622, X, True)

[Uncle Michael]

I may be naive, but since a vb.net script is compiled before running, what effect does the structure of the text file have on the efficiency of the output executable file?

It has always been my goal to make the input file as readable as possible. I've never worried about making it compact. Is there a better way?

[jon00]

For your first question, dealing with a basic HomeSeer script, probably nothing.

With more complex examples which take time to execute, the choice of routine/methods can impact on the overall performance of the script.

Here is a discussion regarding case vs if then statements: https://stackoverflow.com/questions/...itch-case-in-c

[Guest]

You can shorten it to:

 Dim X As String = hs.DeviceString(2405).Replace(X, "km/h", "").Replace(Y, "rafale", "-").Replace(Z, " ", "")
hs.SetDeviceString(8622, X, True)

Thanks Jon, my revised script now looks like this:

Sub Main(ByVal Parms as String)

Dim Y As String
Dim Z As String
Dim X As String = hs.DeviceString(2405).Replace(X, "km/h", "").Replace(Y, "rafale", "-").Replace(Z, " ", "")

hs.SetDeviceString(8622, X, True)

End Sub

but returns the following

:Exception has been thrown by the target of an invocation.Overload resolution failed because no accessible 'Replace' accepts this number of arguments.

[jon00]

Not awake this morning.

It should have shown:

 Dim X As String = hs.DeviceString(2405).Replace("km/h", "").Replace("rafale", "-").Replace(" ", "")  
hs.SetDeviceString(8622, X, True)

[Guest]

Thanks Jon, works as expected; was wondering why extra variables were still required...
Nice and clean now + something new in my VB toolbox 🙂
Cheers,