Announcement

Collapse
No announcement yet.

Easy Trigger plug-in - Feature Requests

Collapse
This is a sticky topic.
X
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • alexbk66
    replied
    Originally posted by teladog01 View Post
    Also, the "Do not update device last change time if device value does not change" setting on the device's Configuration tab can cause unwanted triggers if unchecked.
    Like what?

    Leave a comment:


  • teladog01
    replied
    Originally posted by jvm View Post

    Just to be sure you're not adding complexity where you don't need it, Is the problem that you used the HomeSeer trigger "This device had a value that was just set" or "This device had its value set or changed" rather than using "This device had a value that just changed"?

    These "set" triggers will trigger even if the new value is the same as the old. This is critical for functions such as using Central Scene button presses.
    However, if you use the "changed" trigger, it must be a changed value.
    Good point.

    Also, the "Do not update device last change time if device value does not change" setting on the device's Configuration tab can cause unwanted triggers if unchecked.

    Leave a comment:


  • jvm
    replied
    Originally posted by Ltek View Post

    would this work? ... $OLDVALUE != $NEWVALUE
    (basically trying to see if the new value is different... getting around an issue I'm seeing with HS3 thinking things have changed when they have not, they were just re-writing the same value.

    Just to be sure you're not adding complexity where you don't need it, Is the problem that you used the HomeSeer trigger "This device had a value that was just set" or "This device had its value set or changed" rather than using "This device had a value that just changed"?

    These "set" triggers will trigger even if the new value is the same as the old. This is critical for functions such as using Central Scene button presses.
    However, if you use the "changed" trigger, it must be a changed value.

    Leave a comment:


  • Ltek
    replied
    Originally posted by spud View Post

    if you are using the trigger:
    "Any device's value in this group had its value set and expression is true"
    or
    "This device had its value set and expression is true"

    yes that would work
    IF MeiKu MeiKu MeiKu - Active App had its value set and $OLDVALUE != $NEWVALUE is true

    Leave a comment:


  • spud
    replied
    Originally posted by Ltek View Post

    would this work? ... $OLDVALUE != $NEWVALUE
    (basically trying to see if the new value is different... getting around an issue I'm seeing with HS3 thinking things have changed when they have not, they were just re-writing the same value.

    if you are using the trigger:
    "Any device's value in this group had its value set and expression is true"
    or
    "This device had its value set and expression is true"

    yes that would work

    Leave a comment:


  • Ltek
    replied
    Originally posted by jvm View Post
    I think you can already do this using the Easy Trigger "Any device's value in this group had its value set and expression is true" function by writing an expression like

    ($OLDVALUE < 5 ) && ($NEWVALUE > 30)
    would this work? ... $OLDVALUE != $NEWVALUE
    (basically trying to see if the new value is different... getting around an issue I'm seeing with HS3 thinking things have changed when they have not, they were just re-writing the same value.


    Leave a comment:


  • jvm
    replied
    Originally posted by cc4005 View Post
    spud, would you consider adding the following trigger?

    IF Any device's value in this group was and becomes...

    Thanks.
    I think you can already do this using the Easy Trigger "Any device's value in this group had its value set and expression is true" function by writing an expression like

    ($OLDVALUE < 5 ) && ($NEWVALUE > 30)


    Leave a comment:


  • cc4005
    replied
    spud, would you consider adding the following trigger?

    IF Any device's value in this group was and becomes...

    Thanks.

    Leave a comment:


  • spud
    replied
    Originally posted by cc4005 View Post

    Yes, thank you spud.

    Another question: do push/pop stacks survive an HS3 restart?
    No

    Leave a comment:


  • cc4005
    replied
    Originally posted by jvm View Post

    These changes are very much appreciated. Thank you for the quick response.
    Yes, thank you spud.

    Another question: do push/pop stacks survive an HS3 restart?

    Leave a comment:


  • jvm
    replied
    Originally posted by spud View Post

    Done in version 3.0.0.59



    it will do nothing, just log an error.


    all the values are thrown away
    These changes are very much appreciated. Thank you for the quick response.

    Leave a comment:


  • spud
    replied
    Originally posted by jvm View Post

    Thank you. Greatly appreciated. As you can probably guess, I'm a strong vote in favor of treating the group push / pop as if it were just a sequence of individual push / pops. I don't think you lose any functionality doing it this way, and you avoid the potential of the unpredictable result that I outlined.
    Done in version 3.0.0.59


    Originally posted by jvm View Post
    1. If you use "Pop from stack and Set Devices(s)" on an empty stack, I'm assuming its basically a "do nothing" operation or the device gets set to its current value, rather than something unpredictable. If that isn't already the case, can you make it work like this so its predictable.
    it will do nothing, just log an error.

    Originally posted by jvm View Post

    2. For the "clear stack" operation, does this operate as a series of "pops" restoring the original value, or are all the values just thrown away? There may be some cases where one wants to throw away everything, while others where you want to go back to the first value pushed onto the stack. I have some ideas where I want to use push / pop of groups for volume control of my chromecast devices where sometimes I may want to use "clear" to throw away any pushed volumes, and other times I want to "clear" all the way back to the original volume. Consider whether this could be an easily added check-box option?

    Thanks again for all this great work you've done on these updates.
    all the values are thrown away

    Leave a comment:


  • jvm
    replied
    Originally posted by spud View Post
    after the device pop you would get Value1 and after the group pop you would get Value2



    If this is the consensus I can change group push and pop so that they act directly on device stacks, I didn't really think a lot about it before coding, in my mind they were separate things.
    Thank you. Greatly appreciated. As you can probably guess, I'm a strong vote in favor of treating the group push / pop as if it were just a sequence of individual push / pops. I don't think you lose any functionality doing it this way, and you avoid the potential of the unpredictable result that I outlined.

    Since you are working on this push/pop code, I thought it would also make sense to identify a few other thoughts which may impact what you are doing.

    1. If you use "Pop from stack and Set Devices(s)" on an empty stack, I'm assuming its basically a "do nothing" operation or the device gets set to its current value, rather than something unpredictable. If that isn't already the case, can you make it work like this so its predictable.

    2. For the "clear stack" operation, does this operate as a series of "pops" restoring the original value, or are all the values just thrown away? There may be some cases where one wants to throw away everything, while others where you want to go back to the first value pushed onto the stack. I have some ideas where I want to use push / pop of groups for volume control of my chromecast devices where sometimes I may want to use "clear" to throw away any pushed volumes, and other times I want to "clear" all the way back to the original volume. Consider whether this could be an easily added check-box option?

    Thanks again for all this great work you've done on these updates.

    Leave a comment:


  • spud
    replied
    Originally posted by jvm View Post
    For the new Group Push, what happens if I push a device (Value1), the device changes (Value2) and I push a group including the device, then the device changes again to Value 3. I then do a device pop to pop the device (what value would I get back), then I do a group pop for the device (what's my final value?)?
    after the device pop you would get Value1 and after the group pop you would get Value2

    Originally posted by jvm View Post
    Normally, I'd expect two pushes followed by two pops to restore the device to its original state - Value 1. But given your description of how the group pop works in the beta, I don't think this is what I get and am concerned there could be race conditions between multiple events if you device-push/pops and group-push/pops in different events that act on the same device but you don't pop back the devices / groups in the correct sequence. If I understand correctly and this is an issue, then for the final release, consider treating the group "Push" as if it were nothing different than a bunch of individual pushes, and the group pop as nothing but a bunch of individual pops so you don't get this kind of race condition and sequencing issue.
    Thanks,
    If this is the consensus I can change group push and pop so that they act directly on device stacks, I didn't really think a lot about it before coding, in my mind they were separate things.

    Leave a comment:


  • spud
    replied
    Originally posted by logman View Post
    Spud,

    Just a quick thank you for all the hard work you put into this plugin. You go waaaaay beyond what I think most folks reasonably expect from a dev. This plugin was great when I first purchased it, but it has been improved by a whole order of magnitude since then with continuous releases that are free of charge. Excellent work and I for one very much appreciate your efforts!

    --Barry

    PS The dynamic groups are da bomb! Have found many uses, especially for motion sensors. It has inspired me to install more motion sensors to cover dead spots, and the ability to automatically have them included into a proper dynamic group is a huge time saver. Thank you!
    Thanks for the kind words!

    Leave a comment:

Working...
X