Announcement

Collapse
No announcement yet.

Error message - should I be concerned?

Collapse
X
 
  • Filter
  • Time
  • Show
Clear All
new posts

    #16
    Well, that narrows it down to a fairly small section of code. I'm still not seeing anything wrong with it so one more try with the new copy I just stuck on my web site?

    This one might even not crash and should narrow it down.
    --
    Bob Paauwe
    ISYInsteon Plug-in
    http://www.bobsplace.com/ISYInsteon/

    Comment


      #17
      Nailed it!

      Thanks Bob. You dealt with that right quick!

      If you need any other debugging lemme know - happy to help!

      mark

      Comment


        #18
        Hi Mark,

        While I'm glad it's working, did you happen to capture the messages now that it's working?

        I didn't really do anything to fix the problem, I just tried to trap failures and output error messages. I'd really like to know what's failing, because nothing in that section of the code should and doesn't on my system.
        --
        Bob Paauwe
        ISYInsteon Plug-in
        http://www.bobsplace.com/ISYInsteon/

        Comment


          #19
          Hi Bob,

          I redid it and screen capped it. Sorry - I couldn't pipe it to file in the dos window that was up - I just captured the 3 scrolled windows of it for you then merged them.

          [edit] the upload here didn't look right to me so I dropboxed it. Here's the link https://www.dropbox.com/s/75p0t0kt15...steon.png?dl=0
          Attached Files

          Comment


            #20
            Thanks! That helps a lot.

            It looks like you have a device that is missing some data, I'm guessing it may be missing the device address information and it was crashing when it tried to add that to the listbox.

            If your screenshots are complete, it may have been a device with a name that starts with 'M'.

            I just put yet another version on my website. This won't dump the whole listbox control but it also may crash again (or may just report an error on the one bad device, I'm not sure if trying to output the info will cause it to crash). I'd like to know what type of device is causing the failure.
            --
            Bob Paauwe
            ISYInsteon Plug-in
            http://www.bobsplace.com/ISYInsteon/

            Comment


              #21
              I dug back into my DOS days (first PC was a TRS-80 lol) and got the text out this time.

              ActionCount called
              ActionCount called
              ActionName called for 1
              ActionFromData called with null/empty data.
              ActionConfigured returning action False
              ActionCount called
              ActionCount called
              ActionName called for 1
              ActionFromData called with null/empty data.
              ActionBuildUI called for action 1
              uid = '_5431_A0'
              UID = 9356
              evRef = 5431
              - Build device list
              - Add controlable devices to list
              Adding device to list failed
              - Mark selected device
              - Build command list
              RETURN: Control:
              <!-- jqDropList DevList_5431_A0_ID598385-->
              <script>
              $(function() {
              $('#DevList_5431_A0_ID598385').change( function() {
              var value = $(this).val();
              value = encodeURIComponent(value);
              var theID;
              var theform =$('#'+$(this)[0].form.id);
              var theData = theform.serialize()+'&id='+'DevList_5431_A0_ID598385';
              commonAjaxPost(theData,'Events');
              });
              });
              </script>
              <select id='DevList_5431_A0_ID598385' name='DevList_5431_A0' class='.jqDropLi
              st' title='Select the device you want to control.' >
              <option selected='selected' value=''>(not set)</option><option value='ADR0001'>
              Auto DR</option><option value='14005'>Back yard/Back Yard Lights - All</option>
              <option value='4932'>Back yard/Guest House Bathroom</option><option value='477
              00'>Back yard/Guest House Patio</option><option value='14 F2 32 1'>Back yard/LI
              GHT - Guest House Bathroom</option><option value='40 6E E0 1'>Back yard/LIGHT -
              Guest House Patio</option><option value='12 F0 74 1'>Back yard/LIGHT - Pool De
              ck</option><option value='2A A5 AB 1'>Back yard/LIGHT - Pool House</option><opt
              ion value='40 77 1 1'>Back yard/LIGHT - Pool water</option><option value='3419
              '>Back yard/Pool - All Lights</option><option value='14006'>Back yard/Pool Deck
              </option><option value='13245'>Back yard/Pool House</option><option value='500
              73'>Back yard/Pool Light</option><option value='45887'>Every Light in the House
              </option><option value='40710'>Games Room/Games Closet</option><option value='
              24276'>Games Room/Games Room - All Lights</option><option value='8068'>Games Ro
              om/Games Room - Bar Lights</option><option value='24982'>Games Room/Games Room
              - Fireplace</option><option value='42602'>Games Room/Games Room - Hall Light</o
              ption><option value='27139'>Games Room/Games Room Lights</option><option value
              ='B DE FD 1'>Games Room/LIGHT - Bar</option><option value='9 7A 38 1'>Games Roo
              m/LIGHT - Closet in Games Room</option><option value='A 54 8 1'>Games Room/LIGH
              T - Fireplace in Games Ro</option><option value='13 0 D3 1'>Games Room/Light -
              Games Room - Hall</option><option value='A 51 88 1'>Games Room/TRIGGER - Games
              Room</option><option value='36525'>Garage/Shop/Driveway Light</option><option
              value='41379'>Garage/Shop/Garage - All Lights Off</option><option value='39338'
              >Garage/Shop/Garage Addition</option><option value='B DE 86 1'>Garage/Shop/LIGH
              T - Driveway</option><option value='10 A8 E0 1'>Garage/Shop/LIGHT - G2 - Outsid
              e</option><option value='C 80 93 1'>Garage/Shop/LIGHT - G2 Inside</option><opti
              on value='5 F7 DC 1'>Garage/Shop/LIGHT - Garage Man door</option><option value
              ='5 F7 7F 1'>Garage/Shop/LIGHT - Shop Addition</option><option value='53068'>Ga
              rden/Garden Lights - Back yard</option><option value='8194'>Garden/Garden Light
              s - Pond</option><option value='25339'>Garden/Guest Lights</option><option val
              ue='14 7B 36 1'>Garden/Low Voltage - East</option><option value='14 7B E5 1'>Ga
              rden/Low Voltage - Path Down</option><option value='14 7E 7 1'>Garden/Low Volta
              ge - Patio</option><option value='37 EF 6B 1'>Garden/Low Voltage - Pond Lower</
              option><option value='1C 10 83 1'>Garden/Low Voltage - Pond Upper</option><opti
              on value='23 C 5A 1'>Garden/Low Voltage - West garden</option><option value='6
              977'>Garden/Patio Low Voltage Lights</option><option value='13 FC F5 1'>Garden/
              Pond pump</option><option value='37 E9 10 1'>Garden/PUMP - Hydroponic flood pum
              p</option><option value='48373'>Ground Floor/Ground floor - All Lights Off</opt
              ion><option value='54142'>Ground Floor/Hall Lights - All</option><option value
              ='34764'>Guest Modes/Guest Mode Switches</option><option value='8636'>Kids Floo
              r/Attic</option><option value='C 80 58 1'>Kids Floor/Attic - New</option><optio
              n value='57215'>Kids Floor/Hall - Second Floor</option><option value='22734'>K
              ids Floor/Jordan&#39;s Room/.Jordans Lights</option><option value='41636'>Kids
              Floor/Jordan&#39;s Room/Jordan - Recessed</option><option value='15409'>Kids Fl
              oor/Jordan&#39;s Room/Jordan - Room Lights</option><option value='26942'>Kids F
              loor/Jordan&#39;s Room/Jordan - Under Bed Lighting</option><option value='47847
              '>Kids Floor/Jordan&#39;s Room/Jordan Room 2016</option><option value='48527'>K
              ids Floor/Jordan&#39;s Room/Jordans Closet</option><option value='29 51 B5 6'>K
              ids Floor/Jordan&#39;s Room/KPL - Jordan - Bedside - Clos</option><option value
              ='29 51 B5 4'>Kids Floor/Jordan&#39;s Room/KPL - Jordan - Bedside - Midd</option
              ><option value='29 51 B5 5'>Kids Floor/Jordan&#39;s Room/KPL - Jordan - Bedside
              - Unde</option><option value='29 51 B5 3'>Kids Floor/Jordan&#39;s Room/KPL - J
              ordan - Bedside - West</option><option value='29 51 B5 1'>Kids Floor/Jordan&#39
              ;s Room/KPL - Jordan - Room Lights</option><option value='22 84 80 1'>Kids Floo
              r/Jordan&#39;s Room/LIGHT - Jordan - Closet</option><option value='13 BE 5F 1'>
              Kids Floor/Jordan&#39;s Room/Light - Jordan - Recessed</option><option value='1
              3 BD 11 1'>Kids Floor/Jordan&#39;s Room/LIGHT - Jordan - Track</option><option
              value='17 F4 29 1'>Kids Floor/Jordan&#39;s Room/LIGHT - Jordan - under bed</opti
              on><option value='50955'>Kids Floor/Kids Floor - All</option><option value='22
              456'>Kids Floor/Kids nighttime lights for mot</option><option value='13 0 38 1'
              >Kids Floor/LIGHT - 2ndFloorHall</option><option value='5 F5 2F 1'>Kids Floor/L
              IGHT - Kids Bathroom</option><option value='13 BD 32 1'>Kids Floor/Sara&#39;s R
              oom/LIGHT - Sara - West</option><option value='13 BB E5 1'>Kids Floor/Sara&#39;
              s Room/LIGHT - Sara East</option><option value='26000'>Kids Floor/Sara&#39;s Ro
              om/Sara - All</option><option value='5891'>Kids Floor/Sara&#39;s Room/Sara - Ea
              st</option><option value='34916'>Kids Floor/Sara&#39;s Room/Sara - West</option
              ><option value='5 F5 ED 1'>Kids Floor/Sara&#39;s Room/Sara Patio</option><optio
              n value='B E1 68 1'>Kids Floor/TRIGGER - 2nd Floor</option><option value='1309
              7'>Kitchen/Accent Lighting</option><option value='46418'>Kitchen/Barbecue Light
              </option><option value='736'>Kitchen/Chandelier</option><option value='13303'>
              Kitchen/Coffee Maker</option><option value='36 66 1F 1'>Kitchen/COFFEE MAKER</o
              ption><option value='37077'>Kitchen/Dinner Mode</option><option value='2A A4 5
              7 1'>Kitchen/KITCH15</option><option value='16008'>Kitchen/Kitchen - All Lights
              </option><option value='52565'>Kitchen/Kitchen - Bank of 15</option><option va
              lue='4983'>Kitchen/Kitchen - Sink Lights</option><option value='20965'>Kitchen/
              Kitchen Lights</option><option value='2A 11 CE 2'>Kitchen/KPL - Kitchen - Main
              Lts</option><option value='2A 11 CE 1'>Kitchen/KPL - Tiffany</option><option v
              alue='2A 11 CE 5'>Kitchen/KPL - Tiffany - Accent Lights</option><option value='
              2A 11 CE 8'>Kitchen/KPL - Tiffany - All Off</option><option value='2A 11 CE 3'>
              Kitchen/KPL - Tiffany - Chandelier</option><option value='2A 11 CE 7'>Kitchen/K
              PL - Tiffany - Coffee</option><option value='2A 11 CE 6'>Kitchen/KPL - Tiffany
              - F</option><option value='2A 11 CE 4'>Kitchen/KPL - Tiffany - Sunroom</option>
              <option value='43 9C 42 3'>Kitchen/KPL-RR-Accent Lights</option><option value=
              '43 9C 42 5'>Kitchen/KPL-RR-Chandelier</option><option value='43 9C 42 4'>Kitch
              en/KPL-RR-Dining Pots</option><option value='43 9C 42 6'>Kitchen/KPL-RR-Guiest
              mode</option><option value='43 9C 42 1'>Kitchen/KPL-RR-Kitchen Lights</option><
              option value='39 7F 13 1'>Kitchen/LIGHT - ACCENT LIGHTS</option><option value=
              '17 7F 83 1'>Kitchen/Light - Chandelier</option><option value='8 32 CD 1'>Kitch
              en/LIGHT - Dining Pots</option><option value='14 FC B7 1'>Kitchen/Light - Tile<
              /option><option value='43 F4 EB 1'>Kitchen/LIGHT-Outdoor by kitchen</option><op
              tion value='60326'>Laundry/Coffee Roasting Timer</option><option value='9097'>
              Laundry/Garage Door Scene</option><option value='64556'>Laundry/Laundry - All</
              option><option value='61190'>Laundry/Laundry - Laptop</option><option value='1
              8578'>Laundry/Laundry - Machines</option><option value='26444'>Laundry/Laundry
              KPLs for sync</option><option value='43 F4 CD 1'>Laundry/LIGHT - Laundry Laptop
              </option><option value='43 EE 66 1'>Laundry/LIGHT - Laundry machines</option><o
              ption value='A 54 C6 1'>Laundry/TRIGGER - Laundry Room</option><option value='
              43 F5 CE 1'>LIGHT - Garage Addition</option><option value='24139'>LivRm/Couch</
              option><option value='28092'>LivRm/Fireplace</option><option value='17 7A AF 1
              '>LivRm/LIGHT - Living Room - Foosbal</option><option value='B DF 2C 1'>LivRm/L
              IGHT - Living Room Couch</option><option value='36 5E 8B 1'>LivRm/LIGHT - LR -
              Lamp</option><option value='30219'>LivRm/Living Room - All Lights</option><opti
              on value='10886'>LivRm/Living Room - Floor Lamp</option><option value='24205'>
              LivRm/Living Room - Foosball Table</option><option value='47670'>Main Floor/Ent
              ry Light</option><option value='17128'>Main Floor/Foyer</option><option value=
              '8574'>Main Floor/Front Door - Outside</option><option value='11743'>Main Floor
              /Hall - Main Floor</option><option value='3 96 24 1'>Main Floor/LIGHT - Foyer</
              option><option value='B 91 54 1'>Main Floor/LIGHT - Hanging over entry</option>
              <option value='3D 1F 23 1'>Main Floor/LIGHT - Mainhall new</option><option val
              ue='12 FF B0 1'>Main Floor/LIGHT - Mainhall2</option><option value='7 2F 2F 1'>
              Main Floor/LIGHT - Music Room</option><option value='56202'>Main Floor/Main Flo
              or - All Off</option><option value='61431'>Main Floor/Music Room</option><optio
              n value='3 85 E3 1'>Main Floor/TRIGGER - Foyer</option><option value='8 8F A0
              1'>Main Floor/TRIGGER - Main Hall Pots</option><option value='13 A E 1'>Master
              Bedroom/BLANKET - Mark</option><option value='40522'>Master Bedroom/Blanket - M
              arks Side</option><option value='14770'>Master Bedroom/Blanket - Naz</option><o
              ption value='11 53 9A 1'>Master Bedroom/BLANKET - Naz</option><option value='3
              7018'>Master Bedroom/Blankets - Both</option><option value='26347'>Master Bedro
              om/Ensuite - Pot Lights</option><option value='8 66 4B 1'>Master Bedroom/LIGHT
              - Ensuite Pendant</option><option value='13 BD 0 1'>Master Bedroom/LIGHT - Ensu
              ite Pots</option><option value='8 60 AB 1'>Master Bedroom/LIGHT - Spiral</optio
              n><option value='31370'>Master Bedroom/Loft Lights</option><option value='3093
              2'>Master Bedroom/Master Bedroom - Panic</option><option value='50506'>Master B
              edroom/Master Bedroom Reading Light</option><option value='59956'>Master Bedroo
              m/MB - All Lights Off</option><option value='3D 2A 20 1'>Master Bedroom/Towel W
              armer</option><option value='B E3 B2 1'>Master Bedroom/TRIGGER - Loft</option><
              option value='A 47 8B 1'>Master Bedroom/TRIGGER - Spiral</option></select>

              Comment


                #22
                That looks like the same output as before, maybe if forgot to actually copy the new version to my web server.

                Anyway, I just copied a new version and this time I added a 'a' to the version that is printed in console. So the first line in the console output should have the version as 3.0.0.35a.

                http://www.bobshome.net/homeseer/HSPI_ISYInsteon.exe
                --
                Bob Paauwe
                ISYInsteon Plug-in
                http://www.bobsplace.com/ISYInsteon/

                Comment


                  #23
                  This is different...

                  ISYInsteon Connected, waiting to be initialized...
                  ISYInsteon Registered.
                  ActionFromData called with null/empty data.
                  ActionConfigured returning action False
                  ActionCount called
                  ActionCount called
                  ActionName called for 1
                  ActionFromData called with null/empty data.
                  ActionBuildUI called for action 1
                  uid = '_5431_A0'
                  UID = 9356
                  evRef = 5431
                  Failed to add device 'Kids Floor/Sara's Room/Sara Patio' with addres '8911' to l
                  ist
                  Failed to add device 'My Programs/Alarm/New Program' with addres 'P22' to list
                  Failed to add device 'Deprecated' with addres 'VAR_1_5' to list
                  Failed to add device 'deprecated' with addres 'VAR_2_15' to list
                  ActionCount called
                  ActionCount called
                  ActionName called for 1
                  ActionFromData called with null/empty data.
                  ActionConfigured returning action False
                  ActionCount called
                  ActionCount called
                  ActionName called for 1
                  ActionFromData called with null/empty data.
                  ActionBuildUI called for action 1
                  uid = '_5431_A0'
                  UID = 3345
                  evRef = 5431
                  Failed to add device 'Kids Floor/Sara's Room/Sara Patio' with addres '8911' to l
                  ist
                  Failed to add device 'My Programs/Alarm/New Program' with addres 'P22' to list
                  Failed to add device 'Deprecated' with addres 'VAR_1_5' to list
                  Failed to add device 'deprecated' with addres 'VAR_2_15' to list

                  Comment


                    #24
                    I'm going to guess that the 4 devices that are failing have names that match another device. At least when I create two variables with the same name, I get the second one failing like this.

                    The ISY doesn't care about duplicate names and neither does the plug-in, in general, but the drop down list apparently does.
                    --
                    Bob Paauwe
                    ISYInsteon Plug-in
                    http://www.bobsplace.com/ISYInsteon/

                    Comment


                      #25
                      Gotcha - I'll try changing the names to unique, reload them into your plugin, and try it again.

                      mark

                      Comment


                        #26
                        I can fix it, but it may be rather confusing to have two devices on the list with the same name.

                        Usability question for you, would it make sense to add the device address to the string that makes up the drop-down list? That would make the names unique.

                        Maybe do something like "device name (address)" or "device name [address]"
                        --
                        Bob Paauwe
                        ISYInsteon Plug-in
                        http://www.bobsplace.com/ISYInsteon/

                        Comment


                          #27
                          Ok - so first things first. You're right. It's duplicate names. With variables it actually spans across both integer and state - ie if you have an int variable and state variable with the same names then it breaks it.

                          As for usability.... I think my preference would be something that

                          a) doesn't make the name too long
                          b) doesn't mess with the alphabetical sorting
                          c) clarifies what you're looking at re: int var, state var, program, scene, device

                          So perhaps variables could

                          s_statevar [S2:3]
                          i_intvar [I1:16]

                          Programs similarly could be

                          guest_lights_off [P8122]

                          maybe scenes could have a [Cxxxx] and devices a [Dxxxx]


                          Does that seem reasonable?

                          Oh - and thanks so much for fixing that!

                          mark

                          Comment


                            #28
                            I played around with using 'device name [address]' and wasn't real happy with the results. While it does make them unique, it seems to clutter up the list and make it harder to read. I spent some time trying to space out the address portion so that it would look more like two columns in the list, but can't get that to work. The control doesn't have any type of multi-column support and the browser will just collapse multiple spaces into one. So unless I try to write a custom control for that,...

                            I'm now thinking of just marking the duplicates with either the address or '(dup)'. My thinking is that, in general, duplicate names aren't common or terribly useful so this should be an exception.
                            --
                            Bob Paauwe
                            ISYInsteon Plug-in
                            http://www.bobsplace.com/ISYInsteon/

                            Comment


                              #29
                              Sounds good to me.

                              Most of my duplicates are because my ISY and my webpage work with each other. When I remove a variable I label it 'deprecated' so that I know the spot is available and so that I don't shuffle the variables around and break the relationship between them in their table and my website which addresses them by that position and not by name.

                              My use is likely different than most, though, and so long as the plugin doesn't break when loading duplicates then just putting a [dup] beside them is going to be just fine.

                              Thanks,

                              mark

                              Comment

                              Working...
                              X